Update cantera and pyrometheus dependencies #1053
Conversation
Removed Python setup step from the workflow.
|
CodeAnt AI is reviewing your PR. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughReplaced Python 3.13 with 3.14 in CI; loosened Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
codeant-ai
bot
added
the
size:XS
|
CodeAnt AI finished reviewing your PR. |
![qodo-merge-pro[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR updates chemistry-related Python dependencies by relaxing the Cantera version constraint and switching the Pyrometheus Git repository source.
- Relaxes Cantera version from
==3.1.0to>=3.1.0to allow newer versions - Changes Pyrometheus source from
wilfonba/pyrometheus-wilfongtosbryngelson/pyrometheus-bryngelson(both usingOpenMPTestbranch) - Removes explicit Python 3.13 setup step from CI workflow (Python still installed via system packages)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| toolchain/pyproject.toml | Updates Cantera version constraint to allow >=3.1.0 and changes Pyrometheus repository source |
| .github/workflows/test.yml | Removes explicit Python 3.13 setup action (Python still installed via brew/apt) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/test.yml(0 hunks)toolchain/pyproject.toml(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/test.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
- GitHub Check: Oak Ridge | Frontier (CCE) (gpu)
- GitHub Check: Georgia Tech | Phoenix (NVHPC) (cpu)
- GitHub Check: Self Hosted (gpu, omp, frontier)
- GitHub Check: Github (macos, mpi, no-debug, false)
- GitHub Check: Github (ubuntu, mpi, debug, false)
- GitHub Check: Github (ubuntu, mpi, no-debug, true)
- GitHub Check: Self Hosted (cpu, none, gt)
- GitHub Check: Self Hosted (gpu, acc, gt)
- GitHub Check: Github (ubuntu, mpi, debug, true)
- GitHub Check: Github (ubuntu, no-mpi, single, no-debug, false)
- GitHub Check: Github (macos, mpi, debug, false)
- GitHub Check: Self Hosted (cpu, none, frontier)
- GitHub Check: Self Hosted (gpu, omp, gt)
- GitHub Check: Github (ubuntu, mpi, no-debug, false)
- GitHub Check: Self Hosted (gpu, acc, frontier)
- GitHub Check: Coverage Test on CodeCov
- GitHub Check: Code Cleanliness Check
- GitHub Check: Build & Publish
🔇 Additional comments (2)
toolchain/pyproject.toml (2)
40-42: Verify compatibility with tested Python versions given Python 3.13 CI removal.The AI summary mentions that Python 3.13 was removed from the CI workflow. Combined with the dependency updates to cantera and pyrometheus, ensure that:
- The remaining tested Python versions (e.g., 3.9, 3.10, 3.11, 3.12) are all compatible with
cantera>=3.1.0and the newpyrometheus-bryngelsonfork.- The reason for Python 3.13 removal is documented (incompatibility vs. intentional dropping of support).
Run the following verification to confirm compatibility:
- Check cantera's official documentation for Python version support for 3.1.0 and later.
- Check pyrometheus-bryngelson repository for Python version compatibility claims in its
pyproject.toml,setup.py, or README.
40-40: Based on my verification of the codebase, I can now provide a definitive assessment:The codebase uses only stable core Cantera APIs:
ct.Solution()for loading solutions from files andct.ReactorNet()for reactor network analysis. No deprecated APIs—such assetState_*calls,GasKinetics(replaced byBulkKineticsin 3.0), oradd_data_directory(deprecated in 3.2.0b1)—are present in the code.Cantera 3.1.0 already removed features deprecated in 3.0, establishing a clean upgrade path. The APIs used here are fundamental and stable across the 3.x series.
The version constraint loosening from
==3.1.0to>=3.1.0is safe for this codebase. No code changes are required, and compatibility with Cantera 3.2.0+ is confirmed.
|
You should be able to replace Pyro with release 1.0.6. I have a branch to do this, but I didn't finish building on Frontier yet. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 44.35% 44.36%
=======================================
Files 71 71
Lines 20590 20590
Branches 1994 1994
=======================================
+ Hits 9132 9134 +2
+ Misses 10313 10310 -3
- Partials 1145 1146 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i want to be compatible with cantera 3.2 since that's compatible with python 3.14, though |
|
CodeAnt AI is running Incremental review |
codeant-ai
bot
added
size:XS
|
CodeAnt AI Incremental review completed. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
CodeAnt AI is running Incremental review |
codeant-ai
bot
added
size:XS
|
CodeAnt AI Incremental review completed. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
toolchain/pyproject.toml (1)
40-40: Cantera version constraint allows breaking changes from future releases.The relaxation from
==3.1.0to>=3.1.0provides flexibility but permits future Cantera versions that may introduce breaking API changes. Consider using a pessimistic constraint like~=3.1.0if stricter compatibility bounds are needed:- "cantera>=3.1.0", + "cantera~=3.1.0",However, if your intent is to support Cantera 3.2+ (as mentioned in comments for Python 3.14 compatibility), verify that your codebase is compatible with the latest Cantera versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
toolchain/pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Coverage Test on CodeCov
- GitHub Check: Github (macos, mpi, debug, false)
- GitHub Check: Self Hosted (gpu, omp, gt)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Code Cleanliness Check
- GitHub Check: Build & Publish
🔇 Additional comments (1)
toolchain/pyproject.toml (1)
40-42: I'm unable to verify the review comment due to persistent repository access issues in the sandbox environment. Both the repository clone and GitHub CLI queries have failed, preventing me from:
- Accessing the actual PR description/objectives
- Reading the current
toolchain/pyproject.tomlfile content- Checking git history (commit 167f909)
- Verifying the actual state of the dependency specifications
Pyrometheus dependency discrepancy requires manual verification.
The review raises concerns about an alleged mismatch between PR objectives (referencing
sbryngelson/pyrometheus-bryngelson@OpenMPTest) and the actual code (showingpyrometheus/pyrometheus.gitwith no branch/commit). However, without access to the repository and PR details, I cannot confirm:
- Whether the stated PR objectives are accurate
- Whether the code snippet reflects the current state
- Whether the fork/branch strategy was intentionally reversed or represents a misunderstanding
- Whether the commit pinning concern ("addressed in commit 167f909") was actually resolved
Required for verification:
- Confirm the actual pyrometheus URL and reference in
toolchain/pyproject.tomllines 40-42- Verify the stated PR objectives (fork and branch requirements)
- Clarify whether switching to the official
pyrometheus/pyrometheus.gitrepo is intentional- Add commit hash pinning if using a VCS URL for reproducibility
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
toolchain/modules (2)
37-41: Unversionedpythonmodule on GT Phoenix may affect reproducibilitySwitching
p-allfrom a pinnedpython/<version>to barepythonmakes the environment follow the cluster’s default Python, which can change over time and potentially drift from whattoolchain/pyproject.tomlexpects (Cantera ≥3.1.0, pyrometheus, and the CI’s 3.14 target).If you rely on a minimum Python version (e.g., 3.11+ or 3.14-compatible), consider either:
- pinning to the corresponding
python/<version>module, or- at least confirming the current default
pythonon Phoenix meets those requirements and documenting that expectation.
89-97: ConfirmMFC_CUDA_CC=100matches hipergator GPU hardwareThe new
h-gpuline alignsNVHPC_CUDA_HOMEwithCUDA_HOMEand addsMFC_CUDA_CC=100, which looks consistent with other systems’ usage ofMFC_CUDA_CC.Please just verify that:
- hipergator nodes you target are exclusively compute capability 10.0 (or whatever
100maps to in your build system), and- you don’t still need support for older CCs (e.g., 90) on the same cluster, in which case you might want a comma‑separated list as in the other module blocks.
If the hardware is homogeneous and fully on that architecture, this change is fine as‑is.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
toolchain/modules(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-24T21:50:46.879Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .cursor/rules/mfc-agent-rules.mdc:0-0
Timestamp: 2025-11-24T21:50:46.879Z
Learning: Compile with Cray `ftn` or NVIDIA `nvfortran` for GPU offloading; also build CPU-only with GNU `gfortran` and Intel `ifx`/`ifort` for portability
Applied to files:
toolchain/modules
📚 Learning: 2025-11-24T21:50:16.684Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T21:50:16.684Z
Learning: Applies to src/simulation/**/*.{fpp,f90} : Ensure GPU code compiles with Cray ftn, NVIDIA nvfortran, GNU gfortran, and Intel ifx/ifort compilers
Applied to files:
toolchain/modules
📚 Learning: 2025-11-24T21:50:46.879Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .cursor/rules/mfc-agent-rules.mdc:0-0
Timestamp: 2025-11-24T21:50:46.879Z
Learning: Applies to src/simulation/**/*.{fpp,f90} : Do not use OpenACC or OpenMP directives directly; use Fypp macros from `src/common/include/parallel_macros.fpp` instead
Applied to files:
toolchain/modules
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Code Cleanliness Check
- GitHub Check: Coverage Test on CodeCov
- GitHub Check: Github (ubuntu, mpi, no-debug, true)
- GitHub Check: Github (macos, mpi, debug, false)
- GitHub Check: Github (ubuntu, mpi, no-debug, false)
- GitHub Check: Github (ubuntu, no-mpi, single, no-debug, false)
- GitHub Check: Github (ubuntu, mpi, debug, false)
- GitHub Check: Github (ubuntu, mpi, debug, true)
- GitHub Check: Build & Publish
Removed duplicate entries for CSCS Santis in the modules file.
Removed 'cray-python' from the f-all section and added 'python'. Updated f-gpu section to include 'python'.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
toolchain/modules (2)
38-41: Potential redundant Python module in GPU line.
python/3.12.5is specified in bothp-all(line 38) andp-gpu(line 40). Since-allmodules are loaded as common dependencies, this may be redundant. Other cluster entries (Bridges2, Wombat, Expanse, Delta, Oscar, Santis) only specify Python in their-allline.If this duplication is intentional for module load ordering on Phoenix, consider adding a comment explaining the reason. Otherwise, remove
python/3.12.5from line 40.
45-46: Same Python duplication pattern on Frontier.
pythonappears in bothf-all(line 45) andf-gpu(line 46). Same concern as GT Phoenix — if-allmodules are loaded for all build types, specifyingpythonagain in-gpumay be redundant.The AMD-specific modules (
craype-accel-amd-gfx90a,rocprofiler-compute/3.0.0) look appropriate for Frontier's MI250X GPUs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
toolchain/modules(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-24T21:50:16.684Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T21:50:16.684Z
Learning: Applies to src/simulation/**/*.{fpp,f90} : Ensure GPU code compiles with Cray ftn, NVIDIA nvfortran, GNU gfortran, and Intel ifx/ifort compilers
Applied to files:
toolchain/modules
📚 Learning: 2025-11-24T21:50:46.879Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .cursor/rules/mfc-agent-rules.mdc:0-0
Timestamp: 2025-11-24T21:50:46.879Z
Learning: Compile with Cray `ftn` or NVIDIA `nvfortran` for GPU offloading; also build CPU-only with GNU `gfortran` and Intel `ifx`/`ifort` for portability
Applied to files:
toolchain/modules
📚 Learning: 2025-11-24T21:50:46.879Z
Learnt from: CR
Repo: MFlowCode/MFC PR: 0
File: .cursor/rules/mfc-agent-rules.mdc:0-0
Timestamp: 2025-11-24T21:50:46.879Z
Learning: Applies to src/simulation/**/*.{fpp,f90} : Do not use OpenACC or OpenMP directives directly; use Fypp macros from `src/common/include/parallel_macros.fpp` instead
Applied to files:
toolchain/modules
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Code Cleanliness Check
- GitHub Check: Coverage Test on CodeCov
- GitHub Check: Github (macos, mpi, debug, false)
- GitHub Check: Github (ubuntu, no-mpi, single, no-debug, false)
- GitHub Check: Github (macos, mpi, no-debug, false)
- GitHub Check: Github (ubuntu, mpi, no-debug, false)
- GitHub Check: Github (ubuntu, mpi, debug, true)
- GitHub Check: Github (ubuntu, mpi, debug, false)
- GitHub Check: Github (ubuntu, mpi, no-debug, true)
- GitHub Check: Oak Ridge | Frontier (CCE) (gpu)
- GitHub Check: Georgia Tech | Phoenix (NVHPC) (cpu)
- GitHub Check: Oak Ridge | Frontier (CCE) (gpu)
- GitHub Check: Georgia Tech | Phoenix (NVHPC) (gpu)
- GitHub Check: Build & Publish
🔇 Additional comments (1)
toolchain/modules (1)
85-93: No action required—hipergator is confirmed to have Blackwell B200 GPUs deployed.HiPerGator has 63 DGX B200 nodes with 8 Blackwell B200 GPUs per node (504 Blackwell GPUs total).
MFC_CUDA_CC=100correctly targets this hardware, and CUDA 12.8.1 is compatible with Blackwell. The configuration is appropriate for the deployed cluster.
2 participants
User description
User description
Update dependency
PR Type
Enhancement, Other
Description
Update
canteradependency to flexible version constraint (>=3.1.0)Switch
pyrometheusrepository to official bryngelson forkRemove Python 3.13 setup from CI test workflow
Diagram Walkthrough
File Walkthrough
pyproject.toml
Update chemistry dependencies and repository sourcestoolchain/pyproject.toml
canterafrom pinned version3.1.0to flexible constraint>=3.1.0pyrometheusrepository fromwilfonba/pyrometheus-wilfongtosbryngelson/pyrometheus-bryngelsonOpenMPTestbranch referencetest.yml
Remove Python 3.13 from test workflow.github/workflows/test.yml
actions/setup-python@v5action for Python 3.13CodeAnt-AI Description
Update chemistry dependencies and CI to match modern Python tooling
What Changed
Impact
✅ Chemistry stack tracks maintained releases✅ pyrometheus installs from official repository builds✅ Tests cover Python 3.14 runtime💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.