Ib restart hotfix

[danieljvickers]

Description

Adjusts the ib resetart data to use >0 instead of /= 0 for the case of when we use adaptive time stepping at t_step_start is dflt_int

Also threw in a correction for a torque sign error that I noticed while I was at it.

Type of change

• Bug fix

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request contains two changes to the simulation codebase. In the collision handling module, the torque update applied to the second colliding immersed boundary was changed from subtraction to addition. In the data output module, the restart logic for the immersed boundary state file was modified to distinguish between initial runs and restart scenarios by checking if the start step is greater than zero instead of not equal to zero. These changes affect collision force calculations and file output restart behavior respectively.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description lacks required sections from the template including Testing section, Checklist items, and GPU changes expansion despite modifying src/simulation/.	Add Testing section explaining how changes were tested, complete the Checklist items, and expand GPU changes section to confirm CPU/GPU parity and testing.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Ib restart hotfix' is concise and directly related to the main changes, which involve restart logic fixes for immersed-boundary restart data.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 292ccbb5-3753-4190-9dba-2a65443c96e5

📥 Commits

Reviewing files that changed from the base of the PR and between f3cfba8 and b497afc.

📒 Files selected for processing (2)

• src/simulation/m_collisions.fpp
• src/simulation/m_data_output.fpp

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.62%. Comparing base (f3cfba8) to head (b497afc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/simulation/m_collisions.fpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files          71       71           
  Lines       18407    18407           
  Branches     1516     1516           
=======================================
  Hits        11895    11895           
  Misses       5555     5555           
  Partials      957      957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.