Debug airfoil sign error

[danieljvickers]

Description

The levelsets of airfoils have a sign error, causing them to point into the aifoil rather than away. This causes the airfoil IB to suck in fluid rather than repel it. This is very evident in low mach numbers and causes instabilities.

Type of change

• Bug Fix

Checklist

• I added or updated tests for new behavior
• I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)

• GPU results match CPU results
• Tested on NVIDIA GPU or AMD GPU

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[github-actions]

Claude Code Review

Head SHA: 418efe8

Files changed:

• 1
• src/simulation/m_compute_levelset.fpp

Findings

1. s_airfoil_levelset (2D): upper and lower surfaces now use opposing normal conventions

The PR reverses dist_vec for the lower surface only, leaving the upper surface unchanged. After this diff:

• Upper surface (unchanged): dist_vec = xy_local - airfoil_grid_u(global_id) — vector points from surface point toward ghost point (outward)
• Lower surface (changed): dist_vec = airfoil_grid_l(global_id) - xy_local — vector points from ghost point toward surface (inward)

Both branches feed directly into:

gp%levelset_norm = matmul(rotation, dist_vec(:))/dist

For a 2D airfoil, levelset_norm now points outward for ghost points above the chord line and inward for ghost points below it. This inconsistent sign on the lower-surface normal will corrupt boundary condition enforcement at those ghost points.

2. s_3d_airfoil_levelset (3D): all surface normals now point inward

Both the upper and lower branches of the 3D subroutine are flipped. The resulting dist_vec in every branch now points from the ghost point toward the nearest surface point (inward), and is stored directly as:

gp%levelset_norm = matmul(rotation, dist_vec(:)/dist_surf)

Every other geometry in this module (s_circle_levelset, s_sphere_levelset, s_rectangle_levelset, s_cuboid_levelset) builds dist_vec as ghost_point_position − surface_point_position, yielding an outward-pointing normal. The post-PR 3D airfoil normals are systematically reversed relative to the module convention, producing wrong wall-normal directions for IB boundary conditions in 3D.

[codecov]

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.31%. Comparing base (ab146e9) to head (d8faa14).

Files with missing lines	Patch %	Lines
src/simulation/m_compute_levelset.fpp	26.66%	11 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files          72       72           
  Lines       19771    19771           
  Branches     2852     2852           
=======================================
  Hits        12123    12123           
  Misses       5699     5699           
  Partials     1949     1949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbryngelson]

@danieljvickers have a look at the claude comments for a double check

[danieljvickers]

@sbryngelson Comment 1 is correct. I just pushed a commit for the lines I missed. Comment 2 is backwards. My version of the 3D is correct.

[danieljvickers]

@sbryngelson The Phoenix runners are auto-canceling after submission. I know Phoenix was down yesterday, but I also saw that it was brought back online after repairs. Do the runners need to be reset?

[sbryngelson]

@danieljvickers thank you for your comment. I'm aware of the situation and just haven't had a chance to reboot everything today.

[sbryngelson]

@danieljvickers runners are healthy again