Skip to content

Conversation

@simmsa
Copy link
Contributor

@simmsa simmsa commented Oct 17, 2025

This is a fix for:

https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/18594536347/job/53017269068#step:6:14

Run pip install 'mhkit[all]' --no-index --find-links dist/
Looking in links: dist/
Processing ./dist/mhkit-1.0.1-py3-none-any.whl
INFO: pip is looking at multiple versions of mhkit[all] to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement numpy>=2.0.0 (from mhkit[all]) (from versions: none)
ERROR: No matching distribution found for numpy>=2.0.0
Error: Process completed with exit code 1.

This fix removes --no-index which caused pip to only use local packages, which causes the above failure for any/all external packages/modules.

@simmsa simmsa marked this pull request as ready for review October 17, 2025 15:55
@simmsa
Copy link
Contributor Author

simmsa commented Oct 17, 2025

@akeeste, this is good to go. This should solve the above test failure. This adds a new action: https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/18597697846/job/53028120592 to verify the wheel build in develop. We may not need to keep this, but I wanted to verify that the pip command changes worked before we run the pypi.yml jobs.

@simmsa simmsa requested a review from akeeste October 17, 2025 15:57
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and will prevent future build failures from getting on pypi. The relevant tests are passing.

@akeeste akeeste merged commit 77b133c into MHKiT-Software:main Oct 17, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants