Skip to content

Add edges vs nodes plotting, improve plotting in general#35

Merged
smoia merged 13 commits into
MIPLabCH:masterfrom
smoia:enh/conplot
Nov 23, 2022
Merged

Add edges vs nodes plotting, improve plotting in general#35
smoia merged 13 commits into
MIPLabCH:masterfrom
smoia:enh/conplot

Conversation

@smoia
Copy link
Copy Markdown
Collaborator

@smoia smoia commented Nov 21, 2022

Proposed Changes

  • Add connectome-like plot (viz.plot_edges).

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility label Nov 21, 2022
@smoia smoia added Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) and removed Minormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility labels Nov 21, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2022

Codecov Report

Merging #35 (ac9d639) into master (96f0035) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   90.63%   90.63%   -0.01%     
==========================================
  Files          14       14              
  Lines        1079     1132      +53     
==========================================
+ Hits          978     1026      +48     
- Misses        101      106       +5     
Impacted Files Coverage Δ
nigsp/operations/timeseries.py 91.00% <71.42%> (-1.48%) ⬇️
nigsp/viz.py 97.54% <94.64%> (-2.46%) ⬇️
nigsp/workflow.py 73.73% <100.00%> (ø)

@smoia smoia merged commit 0f1493f into MIPLabCH:master Nov 23, 2022
@smoia smoia deleted the enh/conplot branch November 23, 2022 20:00
@smoia
Copy link
Copy Markdown
Collaborator Author

smoia commented Nov 23, 2022

🚀 PR was released in 0.11.0 🚀

@smoia smoia added the Released This PR has been released! label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) Released This PR has been released!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant