Skip to content

Conversation

@VVX7
Copy link
Contributor

@VVX7 VVX7 commented Apr 10, 2020

update narrative required object fields

@adulau
Copy link
Member

adulau commented Apr 10, 2020

Just discover something in your PR(s). You are changing the UUID of the object template. You should keep the UUID fixed or do you have a specific reason to not do it?

@VVX7
Copy link
Contributor Author

VVX7 commented Apr 10, 2020

It was a mistake changing it in the first place. Now I have a duplicate narrative object I need to remove.

@adulau
Copy link
Member

adulau commented Apr 10, 2020

Don't hesitate to make a new PR with the UUID you want to keep.

@VVX7
Copy link
Contributor Author

VVX7 commented Apr 10, 2020

It is probably better to keep the old one in case anyone else is already using the narrative object. I've removed the duplicate with the new UUID on my instance. Thanks!

@VVX7
Copy link
Contributor Author

VVX7 commented Apr 12, 2020

Hi @adulau this commit also fixes the UUID I changed by mistake back to the original UUID. Should I open a new PR to make this change instead?

@VVX7
Copy link
Contributor Author

VVX7 commented Apr 16, 2020

I've added two new objects to this PR.
Social-media-group for things like facebook pages.
scheduled-event defines an event in meatspace such as upcoming lockdown protests.

@adulau
Copy link
Member

adulau commented Apr 16, 2020

This is great. We will also use for the new modules in AIL for Telegram and other groups that we are discovering new telegram module in AIL

@adulau adulau merged commit fd1aed4 into MISP:master Apr 16, 2020
@VVX7
Copy link
Contributor Author

VVX7 commented Apr 16, 2020

@adulau I added instant-message-group a little while back for Telegram and others. I realllllly to take another look at AIL when I get minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants