Skip to content

Conversation

@VVX7
Copy link
Contributor

@VVX7 VVX7 commented May 31, 2020

#254

avatar-url == background_image
background-image-url == profile_image_url
name == usernamme

Everything else is there except for join_date and join_time which I assumed are satisfied by First seen date and First seen time properties during object creation. Should those fields be used differently?

{
"id": 15171302,
"name": "Alexandre Dulaunoy",
"username": "adulau",
"bio": "Enjoy when human are using machines in unexpected ways. \r I break stuff and I do stuff.",
"location": "Europe",
"url": "http://www.foo.be/",
"join_date": "19 Jun 2008",
"join_time": "10:36 AM",
"tweets": 11460,
"following": 5870,
"followers": 5808,
"likes": 10081,
"media": 641,
"private": 0,
"verified": 0,
"profile_image_url": "https://pbs.twimg.com/profile_images/1248503736957165576/AN7SC5SB_400x400.jpg",
"background_image": "https://pbs.twimg.com/profile_banners/15171302/1509820835/1500x500"
}

@VVX7
Copy link
Contributor Author

VVX7 commented May 31, 2020

Hmm. just took another look at the twitter api and I think you had it right. better to use the twitter keys like profile_image_url. will update later today if I find time.

@adulau
Copy link
Member

adulau commented Jun 1, 2020

Cool thanks! Let me know when I can merge it.

@VVX7
Copy link
Contributor Author

VVX7 commented Jun 2, 2020

Hi @adulau ! I cleaned up the attributes names so they're more in line with the twitter api. This is ready to go now. thanks.

@adulau
Copy link
Member

adulau commented Jun 2, 2020

Thanks a lot, this is a cool work. I’m sure it will be used...

@adulau adulau merged commit 75b71d6 into MISP:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants