Skip to content

Conversation

@mback2k
Copy link
Contributor

@mback2k mback2k commented Jul 2, 2020

Make sure the attributes are sorted like a Cortex taxonomy would normally be displayed/summarized:

namespace:predicate="value" with level as a meta information.

cc @tk-hendrik

@mback2k
Copy link
Contributor Author

mback2k commented Jul 2, 2020

I don't see why the jq CI test fails, I just changed the values inside the existing JSON structure and not the structure itself.

@adulau
Copy link
Member

adulau commented Jul 2, 2020

Thanks a lot for your contribution.

You need to run jq afterwards. I suppose some of the fields were reordered by the ordering is done by jq to keep consistent diff across version of misp-objects.

Make sure the attributes are sorted like a Cortex taxonomy
would normally be displayed/summarized:

`namespace:predicate="value"` with `level` as a meta information.
@adulau adulau merged commit bda4230 into MISP:main Jul 2, 2020
@adulau
Copy link
Member

adulau commented Jul 2, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants