Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
objects/fbi-most-wanted/definition.jsonwhich models FBI API v1 fields such asuid,title,legal-name,alias,images,files,publication,modified,field-office,reward-text, and physical descriptors (height, weight, hair, eyes, scars-and-marks).uidandtitleas required attributes so each instance has a stable identifier and display label.meta-category,name,uuid, andversionfor integration with themisp-objectscollection and tunedui-priority,multiple, anddisable_correlationflags for appropriate attributes../jq_all_the_things.shto canonicalize JSON output.Testing
./jq_all_the_things.shto normalize JSON formatting and it completed in this environment../validate_all.shbut it did not finish because the validation workflow requires a clean working tree and some helper tools are missing in this environment, so full end-to-end validation did not complete.jsonschemavalidation but thejsonschematool was not available (jsonschema: command not found), so schema validation could not be executed here.Codex Task