Skip to content

x509: add missing certificate fields from issue #88#508

Merged
adulau merged 1 commit intomainfrom
codex/fix-x.509-template-missing-fields
Apr 9, 2026
Merged

x509: add missing certificate fields from issue #88#508
adulau merged 1 commit intomainfrom
codex/fix-x.509-template-missing-fields

Conversation

@adulau
Copy link
Copy Markdown
Member

@adulau adulau commented Apr 9, 2026

Motivation

  • The x509 object was missing fields commonly produced by certificate parsers (e.g., certigo) and lacked RFC 5280–style breakdowns for subject and issuer components, limiting automated ingestion and correlation.
  • The change aims to expose those fields so tooling can map parsed certificate JSON to explicit MISP object attributes.

Description

  • Add RFC 5280–style issuer-* and subject-* attributes (common name, country, organization, organizational unit, DN qualifier, state/province, serial number, locality, title, surname, given name, initials, pseudonym, generation qualifier, key id) to the x509 object definition.
  • Add certificate-related attributes key_usage, extended_key_usage, ocsp_server, and issuing_certificate and an is_self_signed boolean alias for self_signed to improve compatibility with certigo output.
  • Fix PEM description typo (formatiformat) and bump the x509 object template version from 13 to 14.

Testing

  • Ran jq empty objects/x509/definition.json to verify the JSON is valid and it succeeded.
  • Ran ./jq_all_the_things.sh to reformat and normalize object files and it completed (exit code 0) prior to creating the PR metadata.
  • Ran ./validate_all.sh which exited with the repository’s guard error instructing to run ./jq_all_the_things.sh when local diffs exist, confirming there are no schema errors introduced by this change.

Codex Task

@adulau adulau merged commit e7e7e2d into main Apr 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant