Align object template names with directory names#515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
"name"value in each object template exactly matches its containing directory slug to avoid tooling and lookup inconsistencies.Description
namefield in six templates so the value exactly matches the directory name:objects/diamond,objects/generalizing-persuasion-framework,objects/nse-script,objects/persnona,objects/rulezet-metadata, andobjects/taranis-news-item.namestring values were changed; no other schema attributes or structure were modified.Testing
objects/<dir>/definition.jsonnameagainst its directory and the script returned no mismatches, indicating success.rg -n '"name"'to inspect the updated files and confirm the newnamevalues are present.Codex Task