Refactor: Remove Some Unused or Deprecated YAML Inputs#75
Merged
sdeastham merged 15 commits intoMIT-LAE:mainfrom Aug 7, 2025
Merged
Refactor: Remove Some Unused or Deprecated YAML Inputs#75sdeastham merged 15 commits intoMIT-LAE:mainfrom
sdeastham merged 15 commits intoMIT-LAE:mainfrom
Conversation
Contributor
Author
|
@sdeastham This PR is now ready for your review. Thanks in advance! |
Collaborator
|
Confirmed zero diff for the standard test. Approved to go in. |
Open
AlphaBetaGammaChi
pushed a commit
to AlphaBetaGammaChi/HAPCEMM-Chem
that referenced
this pull request
Apr 11, 2026
* Remove unnecessary inputs from Meteorology * Modify the Input object in LAGRID initialization * Remove legacy error message in Main * Clean up the Input constructor and methods * Remove unused options from the yaml file * Include the change in the plume model header * Remove a const expression * Initialize the input * Remove a met argument in Aircraft * Remove a rogue comma * Remove an invalid variable reference * Remove a TODO that has been addressed * Rename userDepth and force depth to be from met * Make the variables not const in the wrappers * Remove a const from the main
AlphaBetaGammaChi
pushed a commit
to AlphaBetaGammaChi/HAPCEMM-Chem
that referenced
this pull request
Apr 11, 2026
* Remove unnecessary inputs from Meteorology * Modify the Input object in LAGRID initialization * Remove legacy error message in Main * Clean up the Input constructor and methods * Remove unused options from the yaml file * Include the change in the plume model header * Remove a const expression * Initialize the input * Remove a met argument in Aircraft * Remove a rogue comma * Remove an invalid variable reference * Remove a TODO that has been addressed * Rename userDepth and force depth to be from met * Make the variables not const in the wrappers * Remove a const from the main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following #74, a few locations which still use inputs from the
input.yamlfile (but should not be doing so) were identified. This minor refactor removes some clutter from theinput.yamlfile to improve the user experience. This PR is backwards compatible, so no action is required for users using oldinput.yamlfiles after updating to this version.Refactoring Details
From the
METEOROLOGICAL PARAMETERS SUBMENU, the following parameters were removed in theinput.yamlfile:Temperature [K] (double)R.Hum. wrt water [%] (double)Wind shear [1/s] (double)Removed the following submenus and bools from the
input.yaml:HUMIDITY SCALING OPTIONSIMPOSE MOIST LAYER DEPTH SUBMENUIMPOSE LAPSE RATE SUBMENUAdd diurnal variations (T/F)The rest of the changes involve the following:
YamlInputReaderto omit these terms, and deleted the corresponding member variables fromInput_ModsatdepthUserandsatdepthEstimateto reflect that this comes from the meteorologyAmbientMetParamsInputconstructorInputfor the temperature and relative humidityLAGRIDPlumeModelconstructure to ensure compatibility with the current setupResults
The following results apply to a 500m deep moist layer test case
Table 1: Table showing the change in integral quantities over the lifetime of the contrail.
Figure 1: Table showing the time evolution of contrail variables before and after the changes
Discussion and Conclusion
Table 1 and Figure 1 show no changes to the integrated quantities or the contrail behaviour. The tests were run using a input.yaml from the previous version, so no compatibility or performance issues have been identified.