Fix numerical abs usage in primal-dual residual gap computation#61
Merged
ZedongPeng merged 2 commits intoMIT-Lu-Lab:mainfrom Jan 30, 2026
Merged
Conversation
Collaborator
Author
|
Hi @ZedongPeng, I ran a benchmark comparison between the current version (
From the plot, the solve time is essentially unchanged. The iteration counts differ slightly, and in two cases the difference exceeds 1%. |
Collaborator
|
Thanks for the PR. Could you merge the latest |
Collaborator
Author
|
Done. @ZedongPeng |
ZedongPeng
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR fixes an incorrect use of
abswhen computing the log-scaled primal-dual residual gap during adaptive restart, as noted in issue #60.The previous implementation could invoke the integer version of
abs, leading to unintended type conversion and incorrect behavior for floating-point values.Changes
abs(...)withfabs(...)when computingprimal_dual_residual_gapinperform_restart()