Merged
Conversation
** Why are these changes being introduced: * It has been a while since we updated dependencies of this theme. ** Relevant ticket(s): * n/a - maintenance week ** How does this address that need: * Runs npm update * Bumps theme version ** Document any side effects to this change: * Similar to parent and child themes, we change the theme version in /style.css to 'unbuilt' to give a greater warning should the build ever be skipped during deploys. Eventually this should not be needed but alas for now it is. The theme version is still updated in /css/style.css
Member
Author
|
Merging without code review after review on staging, following our usual maintenance procedure. The only meaningful changes in here are from npm update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
/style.css to 'unbuilt' to give a greater warning should the build
ever be skipped during deploys. Eventually this should not be needed
but alas for now it is. The theme version is still updated in
/css/style.css
Todo:
Requires new or updated plugins, themes, or libraries?
YES
Requires change to deploy process?
NO