This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Write zip file to disk then include it in sword post #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #45 Ideally we’d not write this to disk and instead just generate it on demand and stream it through. It’s likely possible but this was a quick fix and should work fine as it’ll never be run on separate dynos since it’s all once request.
JPrevost
added a commit
that referenced
this pull request
Feb 16, 2016
…empty Write zip file to disk then include it in sword post
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45
Ideally we’d not write this to disk and instead just generate it on
demand and stream it through. It’s likely possible but this was a quick
fix and should work fine as it’ll never be run on separate dynos since
it’s all once request.