TEMP: hide status, and add temp links to view more sidebar #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
reviewed
Feb 27, 2017
| <ul class="list-local-locations"> | ||
| <% result.location.each do |location| %> | ||
| <li class="result-local-location"> | ||
| <%= location[0] %>: <%= location[1] %> (not live) |
Member
There was a problem hiding this comment.
This line shows us the cached status from EDS. It is displayed if anything goes wrong when requesting the realtime information. The text should reflect that it is not realtime information. I don't particularly care what exactly we say, but we should make it clear it is not realtime.
JPrevost
reviewed
Feb 27, 2017
| <li class=""><a href="">Sed diam nonumy eirmod</a></li> | ||
| <li class=""><a href="">Tempor invidunt ut labore</a></li> | ||
| <li class=""><a href="">Dolore magna aliquyam</a></li> | ||
| <li class="http://libraries.mit.edu/bartonplus"><a href="library.mit.edu">Search in BartonPlus</a></li> |
Member
There was a problem hiding this comment.
This css class is probably not what you intended ;)
Also, is there a reason we don't consistently use https when linking to libraries.mit.edu?
Contributor
Author
There was a problem hiding this comment.
... and this is why we have code reviews before merge. 😞 and yes, we should be linking with https. I'll make any changes in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.