Skip to content

TEMP: hide status, and add temp links to view more sidebar #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2017
Merged

TEMP: hide status, and add temp links to view more sidebar #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/aleph/item_status.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<ul class="list-local-locations">
<% @status.each do |s| %>
<li class="result-local-location">
<%= s[:library] %> <%= s[:collection] %>: <%= s[:call_number] %> (<%= s[:status] %>)
<%= s[:library] %> <%= s[:collection] %>: <%= s[:call_number] %>
</li>
<% end %>
</ul>
2 changes: 1 addition & 1 deletion app/views/search/_result.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<ul class="list-local-locations">
<% result.location.each do |location| %>
<li class="result-local-location">
<%= location[0] %>: <%= location[1] %> (not live)
<%= location[0] %>: <%= location[1] %>
Copy link
Member

@JPrevost JPrevost Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line shows us the cached status from EDS. It is displayed if anything goes wrong when requesting the realtime information. The text should reflect that it is not realtime information. I don't particularly care what exactly we say, but we should make it clear it is not realtime.

</li>
<% end %>
</ul>
Expand Down
10 changes: 5 additions & 5 deletions app/views/search/search_boxed.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
</div>
<div class="col1q-r">
<div class="bit">
<h3>Supporting content</h3>
<p>Lorem ipsum dolor sit amet, consetetur sadipscing elitr: </p>
<h3>Other options</h3>
<p>If you're not finding what you need, you can try one of these: </p>
<ul>
<li class=""><a href="">Sed diam nonumy eirmod</a></li>
<li class=""><a href="">Tempor invidunt ut labore</a></li>
<li class=""><a href="">Dolore magna aliquyam</a></li>
<li class="http://libraries.mit.edu/bartonplus"><a href="library.mit.edu">Search in BartonPlus</a></li>
Copy link
Member

@JPrevost JPrevost Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This css class is probably not what you intended ;)

Also, is there a reason we don't consistently use https when linking to libraries.mit.edu?

Copy link
Contributor Author

@frrrances frrrances Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and this is why we have code reviews before merge. 😞 and yes, we should be linking with https. I'll make any changes in the next PR.

<li class=""><a href="http://libraries.mit.edu/worldcat">Search in WorldCat</a></li>
<li class=""><a href="https://libraries.mit.edi/ask">Ask a Librarian</a></li>
</ul>
</div>
</div>
Expand Down