Skip to content

Conversation

@ghukill
Copy link
Contributor

@ghukill ghukill commented Dec 3, 2025

Purpose and background context

This PR performs 2025-12 maintenance on this application:

  • dependencies updated
  • update applied for how the Oracle client is installed in the Docker image

How can a reviewer manually see the effects of these changes?

Unsure if everyone needs to run tests, but I have run them and confirmed that data warehouse + FTP server connection is successful from a local docker container.

1- Set Dev1 credentials

2- Download dependencies and build image:

make dependencies
make dist-dev

3- Update .env file with env vars:

WORKSPACE=dev
FEED_TYPE=articles
ARTICLES_PUBLISH_DAYS_PAST=180
SNS_TOPIC_ARN="arn:aws:sns:us-east-1:222053980223:carbon-ecs-dev"
SYMPLECTIC_FTP_JSON='{...}'
SYMPLECTIC_FTP_PATH='ghtest'
DATAWAREHOUSE_CLOUDCONNECTOR_JSON='{...}'

The actual values for SYMPLECTIC_FTP_JSON and DATAWAREHOUSE_CLOUDCONNECTOR_JSON were retrieved from secrets in stage environment. The data warehouse host was changed to point directly instead of the cloudconnector host.

4- Run connection test:

make run-connection-tests-with-docker

Output:

docker run -v ./.env:/.env carbon-dev --run_connection_tests
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Loading .env environment variables...
2025-12-03 20:37:58,851 INFO root.configure_logger(): Logger 'root' configured with level=INFO
2025-12-03 20:37:58,856 INFO root.configure_sentry(): No Sentry DSN found, exceptions will not be sent to Sentry
2025-12-03 20:37:58,856 INFO carbon.cli.main(): Carbon config settings loaded for environment: dev
2025-12-03 20:37:59,390 INFO carbon.database.run_connection_test(): Testing connection to the Data Warehouse
2025-12-03 20:38:25,642 INFO carbon.database.run_connection_test(): Successfully connected to the Data Warehouse: 19.28.0.0.0
2025-12-03 20:38:25,684 INFO carbon.app.run_connection_test(): Testing connection to the Symplectic Elements FTP server
2025-12-03 20:38:31,436 INFO carbon.app.run_connection_test(): Successfully connected to the Symplectic Elements FTP server

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

Why these changes are being introduced:

Over time, applications that install the Oracle client have
required an update to how dependency libraries are installed.
This time has come for Carbon.

How this addresses that need:

The library `libaio1t64` is installed and symlinked for use.

The same approach was used in hrqb-client and alma-bursartransfer.

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1573
@ghukill ghukill marked this pull request as ready for review December 3, 2025 20:49
@ehanson8 ehanson8 self-assigned this Dec 4, 2025
Copy link
Contributor

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, approved!

@ghukill ghukill merged commit 2014a62 into main Dec 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants