Validate form inputs #7
Conversation
magma/home/__init__.py
Outdated
There was a problem hiding this comment.
@gravesm this line is a bit long but wasn't sure if you prefer the extra line for 4 chars over 80 or not.
There was a problem hiding this comment.
Yeah, I would use:
from flask import (Blueprint, flash, request, render_template, make_response,
session,)There was a problem hiding this comment.
Hey... just checking on style here... you prefer that trailing comma?
There was a problem hiding this comment.
Usually, if I think about it I'll leave a trailing comma. It's pretty common practice in python to do that for any list, especially those you might end up adding to later. Not required though in any sense.
|
👍 Thanks for functional tests. |
|
This was more complicated than I initially assumed mostly due to the difference in testing and real browser environments (as always) and what gets submitted when you don't supply a file for each. Once I figured out what was happening it was practically done. This was a great way for me to jump in on a python project that wasn't already super complicated. I'll fixup the import line, squash and merge. Thanks for the review. |
closes #2
JPrevost
force-pushed
the
2_form_validation
branch
from
520cd64 to
b72175f
Compare
closes #2