Merged
Conversation
Why these changes are being introduced: The vulnerability GHSA-4xh5-x5gv-qwph is triggering an error from pip-audit, but technically running python >= 3.12 is sufficient to mitigate the risk. Until pip releases a new release, even though we have no risk, pip-audit will continue to fail. How this addresses that need: * Explicitly ignores the vulnerability during vulnerability scanning. Side effects of this change: * None Relevant ticket(s): * None
* Update notebook.py with temp CDPS dashboard layout * Update README.md to remove generic info * Update dependencies * Update pyproject.toml to ignore ruff error
ghukill
approved these changes
Oct 7, 2025
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looking like a great start! I ran the notebook and can see that the dropdown selection is utilized in a downstream cell.
Please let me know if you're looking for more feedback on any aspect in particular, but making sense so far.
Collaborator
Author
That's all, thanks! More substantive review required for all subsequent PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
An initial commit to remove generic info from our
marimotemplate repo and add a very rough layout (to be updated in a future ticket after consultation with stakeholders)How can a reviewer manually see the effects of these changes?
To preview the notebook, run
make run-notebookIncludes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?