Conversation
Why are these changes being introduced: * AddThis was not frequently used * The plugin we used was under review and hadn't been updated in a long time and was likely not actually supported Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/LM-361 How does this address that need: * Removes the plugin via composer * Removes the manual javascript inclusion that loaded AddThis from an external site * Removes some styles and custom logic on when to apply them
matt-bernhardt
approved these changes
May 5, 2023
matt-bernhardt
left a comment
matt-bernhardt
left a comment
Member
There was a problem hiding this comment.
This all looks good to me - I've confirmed that addthis isn't being loaded in the review app, and appreciate the thoroughness of removing things like the hide-addthis.css stylesheet, not just getting rid of the plugin and inline call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to see the changes:
There is a multidev (addthis) that this is deployed to. Looking at an individual news item will not display the addthis buttons on that multidev. The same news item viewed in our live tier will have the addthis buttons.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated
Code Reviewer
(not just this pull request message)