Conversation
matt-bernhardt
approved these changes
May 5, 2023
matt-bernhardt
left a comment
matt-bernhardt
left a comment
Member
There was a problem hiding this comment.
I've confirmed that a contributor sees the Add Media button, and that it works to upload a new picture. Thanks for catching this function!
Why are these changes being introduced: * this feature existed in legacy but wasn't working in the rebuilt network Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/LM-350 How does this address that need: * Re-introduces the function from legacy that provide this functionality https://github.com/MITLibraries/MITLibraries-news/blob/master/functions.php#L239 The only change from legacy was to introduce the namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)