Conversation
matt-bernhardt
left a comment
There was a problem hiding this comment.
Short answer: this looks fine, and I've confirmed that this change is necessary for the hours to display on the sites that need them.
Longer, can-of-worms answer: it looks like this change doesn't do quite what I expected it would do - but the thing that is happening is also happening on our legacy site, so 🤷
This change causes the Moment and Underscore libraries to be loaded from somewhere in the WordPress core - not the versions that are in the parent theme's js/libs folder? I'd never noticed that this was happening on the legacy site, and it wasn't until I looked more closely at the network tab that I realized this was happening.
This will probably come back to relevance when we try and update how we handle these internal dependencies - potentially allowing us to just wash our hands of the question - but I don't want to deal with the ramifications now. This change works, and the behavior that it prompts is the same was we see on the legacy site.
![]()
Why are these changes being introduced: * These are required for some hours related functionality Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/LM-191 How does this address that need: * registers and enqueues the two libraries Document any side effects to this change: * The child theme loads all required libs and does not limit them to pages that need them
Update testing.yml to use GITHUB_TOKEN
This seems to resolve date loading on both /docs and /distinctive-collections in the hours multidev environment.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)