Skip to content

Removes facebook from social links section of news posts#97

Merged
JPrevost merged 1 commit into
masterfrom
newsfb
Apr 28, 2023
Merged

Removes facebook from social links section of news posts#97
JPrevost merged 1 commit into
masterfrom
newsfb

Conversation

@JPrevost

@JPrevost JPrevost commented Apr 27, 2023

Copy link
Copy Markdown
Member

The image itself is in a sprite and not worth removing, but the styles felt worthwhile to clean up

https://mitlibraries.atlassian.net/browse/LM-348

Developer

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

@JPrevost JPrevost requested a review from matt-bernhardt April 27, 2023 18:58
@matt-bernhardt matt-bernhardt self-assigned this Apr 27, 2023

@matt-bernhardt matt-bernhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and straightforward - :shipit:

The image itself is in a sprite and not worth removing, but the styles felt worthwhile to clean up

https://mitlibraries.atlassian.net/browse/LM-348
@JPrevost JPrevost merged commit 1392283 into master Apr 28, 2023
@JPrevost JPrevost deleted the newsfb branch April 28, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants