Adds final touches to custom fields across the network#99
Conversation
** Why are these changes being introduced: * The AKDC site on our network has a some custom fields added to its Post content type, which allow this content type to function as an event. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-147 ** How does this address that need: * This defines a site-specific extension for the Mitlib Post plugin family, which will be enabled only on the AKDC site. This is the same approach which we've previously adopted for the Parent and News sites when those sites needed to extend the built-in post types. ** Document any side effects to this change: * This doubles down on using the Post content type when we might really need to use the Events post type - but I'm not going to fight that battle right now.
JPrevost
left a comment
There was a problem hiding this comment.
This looks to do what it intends to do, and I agree we can revisit whether extending Posts or creating new types is better later.
Question regarding migration: did the existing test migrations for akdc bring in event data properly and this just allows us to add/edit/display that data or do we need to confirm that migrations will pull this data in now that we have support for it?
|
One of the quirks here is that the custom fields and field groups are also included in the content export - so the fact that I missed these fields in code initially didn't mean that these fields were left out of the first import. They were just entirely in the content side of things. With this PR, we have the option to remove those items from the content XML (although this isn't necessary). I intend to do this for the final import, FWIW. |
|
@matt-bernhardt lets chat about what the effect of your last comment means in slack or zoom to make sure I understand it. I'm not blocking merging as this is working as intended, but I'd like to ensure I understand what risk we are assuming in the akdc site migrating differently than in the final migration than our last test migration if nothing else. Thanks! |
Why are these changes being introduced:
The AKDC site on our network has a set of custom fields added to its Post content type, which allow this content type to function as an event.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/lm-147
How does this address that need:
This defines a site-specific extension for the Mitlib Post plugin family, which will be enabled only on the AKDC site. This is the same approach which we've previously adopted for the Parent and News sites when those sites needed to extend the built-in post types.
Document any side effects to this change:
This doubles down on using the Post content type for this content, when we might really need to define an Events post type - but that will need to be a coordinated change after we launch the rebuilt site.
Recommended verification for this PR
/akdc/wp-admin/edit.php?post_type=acf-field-group/akdc/wp-admin/post-new.phpand note that there is a "News and Events" field group visible/akdc/wp-admin/post.php?post=2194&action=editDeveloper
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated
Code Reviewer
(not just this pull request message)