Create basic repository structure #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: Since this is a template repository, we want it to have our standard Python CLI app structure with all the usual tools already in place for testing, linting/code quality, exception monitoring, logging, Github Actions, etc. How this addresses that need: * Creates basic app folder with initial cli and config modules. * Creates tests for initial cli and config functionality. * Adds .github folder with PR template, dependabot configuration, and CI workflow. * Adds Dockerfile set up for basic image creation. * Adds Makefile with standard dependency management, testing, and linting commands. * Adds Pipfile with initial package and dev dependencies for testing, linting, and exception monitoring. * Adds setup.cfg with initial pytest and linter configurations. * Adds README with standard dev instructions and an "App setup" section at the top with instructions for creating a new app from this template.
ehanson8
approved these changes
Jul 18, 2022
Contributor
ehanson8
left a comment
ehanson8
left a comment
There was a problem hiding this comment.
A lot of good improvements and I think this will make it a lot easier to evolve our practices over time in a more visible way by updating this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates initial Python CLI app structure with all the usual tools already in place for testing, linting/code quality, exception monitoring, logging, Github Actions, etc.
Includes new or updated dependencies?
YES
Developer
Code Reviewer