IN-894 Remove Pipfile.lock #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * The Pipfile.lock shouldn't be included in the template as it risks pinning standard dependencies to outdated versions; unintentionally committed How this addresses that need: * Remove Pipfile.lock Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-894
ghukill
approved these changes
Oct 13, 2023
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Pipfile.lock removal approved!
ehanson8
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The Pipfile.lock shouldn't be included in the template as it risks pinning standard dependencies to outdated versions; unintentionally committed
What does this PR do?
Remove
Pipfile.lockfrom template repoHelpful background context
Unintentionally committed the Pipfile.lock through PR #7.
How can a reviewer manually see the effects of these changes?
Very minor change! I think the CI passing upon creating this PR is sufficient to show that everything is a-okay!
Includes new or updated dependencies?
NO
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/IN-894
Developer
Code Reviewer
(not just this pull request message)