Skip to content

Conversation

@hakbailey
Copy link
Contributor

What does this PR do?

Removes pyflakes from Pipfile, unpinning the version and letting it be handled as a Pylama subdependency.

Helpful background context

Pylama had a bug with the latest version of pyflakes, so we had to pin the pyflakes version to an older one in order for the linters to work. Pylama has released a version with a fix so we can unpin pyflakes now.

How can a reviewer manually see the effects of these changes?

Run make install and confirm that the installed pyflakes version is 2.5.0 and make lint works as expected (or just review the Github actions log for the same info).

Includes new or updated dependencies?

YES

Developer

  • All new ENV is documented in README (or there is none)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

@hakbailey hakbailey requested a review from ehanson8 August 18, 2022 17:49
@hakbailey hakbailey merged commit 6a61d6b into main Aug 19, 2022
@hakbailey hakbailey deleted the unpin-pyflakes branch August 19, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants