Add Heroku config #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
force-pushed
the
engx-239-tacos-pipeline
branch
from
e5fac6a to
d7e05b9
Compare
Member
|
@jazairi would you mind adding a commit (or opening a ticket) to change prod db to be pg? This still uses sqlite on Heroku. I have no preference as to whether that's a new commit or a new ticket. The rest of this is 👍🏻 so if you prefer the new ticket approach I'll approve. |
jazairi
force-pushed
the
engx-239-tacos-pipeline
branch
from
d12e31a to
fe864e0
Compare
Member
|
Closing and re-opening the PR to test the build process |
JPrevost
approved these changes
Nov 20, 2023
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
I'll open new tickets to get GraphiQL working (it's dev only right now) as well as creating a splash page.
Why these changes are being introduced: We need a Procfile and app.json for our Heroku config. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/ENGX-239 How this addresses that need: This adds a Procfile and app.json with the initial settings we'll need. Side effects of this change: The pg has been added to production.
jazairi
force-pushed
the
engx-239-tacos-pipeline
branch
from
fe864e0 to
fd16f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We need a Procfile and app.json for our Heroku config.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ENGX-239
How this addresses that need:
This adds a Procfile and app.json with the initial settings we'll
need.
Side effects of this change:
None.