Change email 'from' address

[jazairi]

Why these changes are being introduced:

The 'from' and 'to' addresses are currently the same, which causes an unwanted loop in libanswers.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-618

How this addresses that need:

This sets the 'form' address in all mailers to a new env, ETD_APP_EMAIL.

Side effects of this change:

The new env will need to be added to all pipelines.

Developer

• All new ENV is documented in README
• All new ENV has been added to Heroku Pipeline, Staging and Prod
• ANDI or Wave has been run in accordance to
  our guide and
  all issues introduced by these changes have been resolved or opened as new
  issues (link to those issues in the Pull Request details above)
• Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

• The commit message is clear and follows our guidelines
  (not just this pull request message)
• There are appropriate tests covering any new functionality
• The documentation has been updated or is unnecessary
• The changes have been verified
• New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

[coveralls]

Coverage: 97.59%. Remained the same when pulling ecaebad on etd-618-change-email-from-address into b24a359 on main.

[JPrevost]

Can you please email Ben and cc wherever we send the MARC report to in production to let them know the "from" email is changing on the reports they get just in case they care?

[jazairi]

@JPrevost To clarify, Ben should be cc'd on all production emails, or just the first?

[JPrevost]

@jazairi sorry for the confusion in my words :) Neither! Outside of the application, please let Ben know we are making this change in case they use the from for any filtering. cc the address we actually send to in production so everyone on that list also gets the information. We had worked with Ben directly so emailing him directly in addition to the cc seemed worthwhile.