Generate budget report CSV for partially harvested theses#1116
Merged
Conversation
Why these changes are being introduced: We pay ProQuest to harvest metadata from doctoral theses that have not opted in. Each time the export job is run, we need to generate a report of these theses for budget reconciliation. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-616 How this addresses that need: This adds logic to generate the requisite report, which is then generated during the ProquestExportJob and attached the confirmation email. Side effects of this change: Unrelated tests in the Report model have updated due to new fixtures added.
jazairi
force-pushed
the
etd-616-budget-report
branch
from
d411d51 to
95784c8
Compare
JPrevost
approved these changes
Feb 14, 2023
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
I didn't run any reports to confirm any of this as I figured stakeholders would be better at knowing what they need... but the code/tests looks good. Overview docs for this already merged (thanks for writing them so we don't forget!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We pay ProQuest to harvest metadata from doctoral theses that have not opted in. Each time the export job is run, we need to generate a report of these theses for budget reconciliation.
Relevant ticket(s):
How this addresses that need:
This adds logic to generate the requisite report, which is then generated during the ProquestExportJob and attached the confirmation email.
Side effects of this change:
Unrelated tests in the Report model have updated due to new fixtures added.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO