Skip to content

Update theme gem#1139

Merged
jazairi merged 1 commit intomainfrom
update-theme
Mar 27, 2023
Merged

Update theme gem#1139
jazairi merged 1 commit intomainfrom
update-theme

Conversation

@jazairi
Copy link
Copy Markdown
Contributor

@jazairi jazairi commented Mar 27, 2023

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to thesis-submit-pr-1139 March 27, 2023 20:28 Inactive
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage: 98.304%. Remained the same when pulling 8fd4996 on update-theme into cdfb1a2 on main.

@jazairi jazairi merged commit 64f22be into main Mar 27, 2023
@jazairi jazairi deleted the update-theme branch March 27, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants