Skip to content

Update theme gem#1146

Merged
jazairi merged 1 commit intomainfrom
update-footer
Apr 3, 2023
Merged

Update theme gem#1146
jazairi merged 1 commit intomainfrom
update-footer

Conversation

@jazairi
Copy link
Copy Markdown
Contributor

@jazairi jazairi commented Apr 3, 2023

Why these changes are being introduced:

The new theme gem version includes some footer updates requested by UXWS.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/UXWS-1507

How this addresses that need:

This updates the theme gem.

Side effects of this change:

The previous version missed the versions.rb change, so the lockfile will show an increment from 1.0.0 to 1.0.2, when in reality it is from 1.0.1 to 1.0.2.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

Why these changes are being introduced:

The new theme gem version includes some footer updates requested by UXWS.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/UXWS-1507

How this addresses that need:

This updates the theme gem.

Side effects of this change:

The previous version missed the `versions.rb` change, so the lockfile will show an increment from `1.0.0` to `1.0.2`, when in reality it is from `1.0.1` to `1.0.2`.
@mitlib mitlib temporarily deployed to thesis-submit-pr-1146 April 3, 2023 21:00 Inactive
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage: 98.304%. Remained the same when pulling fb59ca8 on update-footer into 64f22be on main.

@jazairi jazairi merged commit 2756415 into main Apr 3, 2023
@jazairi jazairi deleted the update-footer branch April 3, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants