Skip to content

Conversation

@jonavellecuerdo
Copy link
Contributor

Purpose and background context

Remove test code that was added to tim/cli.py. The change was intended to be temporary and was required to run the Visual Studio Code debugger during development.

Note: In order to "hop into" the code with the debugger, I also had run the debugger using the following launch.json:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python Debugger: Current File",
            "type": "debugpy",
            "request": "launch",
            "module": "tim.cli",
            "args": [
                "bulk-update-embeddings",
                "-s",
                "libguides",
                "-d",
                "2025-02-28",
                "-rid",
                "<run-id>",
                "s3://<timdex-bucket>/dataset"
            ],
            "console": "integratedTerminal"
        }
    ]
}

How can a reviewer manually see the effects of these changes?

Not required.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

@jonavellecuerdo
Copy link
Contributor Author

Closing this PR and including the change in this PR: #373.

@jonavellecuerdo jonavellecuerdo deleted the USE-122-remove-test-code branch December 15, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants