Updates repository to use UV and Python 3.14 by JPrevost · Pull Request #7 · MITLibraries/timdex-semantic-builder

JPrevost · 2026-03-03T14:43:32Z

Why are these changes being introduced:

uv is our preferred way to manage Python dependencies and virtual environments
Python 3.14 is the latest stable release.
Some additional changes were made for developer ergonomics in this cross team repository.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/USE-425

How does this address that need:

Copies most of the changes from the upstream PR
Updates to python 3.14
Updates uv to latest
Updates all dependencies
Removes pip-audit from pre-commit hooks as we will manage dependency security concners with renovate via GitHub integration

Document any side effects to this change:

This integrates changes that have not merged into the upstream template repository manually. We may have missed changes or upstream may choose different paths than they were exploring when we copied the changes.

Purpose and background context

Describe the overall purpose of the PR changes and any useful background context.

How can a reviewer manually see the effects of these changes?

Explain how to see the proposed changes in the application if possible.

Delete this section if it isn't applicable to the PR.

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

Include links to Jira Software and/or Jira Service Management tickets here.

Code review

Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

ghukill

Didn't want to formally request changes, but short of an approval are some comments about the option to revert to a uv installed instance of black and the shared linting CI workflow. Unless you opt to move straight to ruff format for formatting, I think it could be a better option than uvx which could be problematic at CI where black may not be installed.

Otherwise, looking good! Nice weaving of POC PR's and other lambda repositories that are utilizing uv and have HTTP server use cases.

ghukill · 2026-03-03T15:43:15Z

pyproject.toml

+dev = [
+    "coveralls>=4.0.1",
+    "ipython>=9.2.0",
+    "mypy>=1.15.0",
+    "pip-audit>=2.9.0",
+    "pre-commit>=4.2.0",
+    "pytest>=8.3.5",
+    "ruff>=0.11.11",
+]


As mentioned in a side-channel discussion, looks like black may have been missed as dev dependency. Running uv add --dev black should do the trick, and it'll get added here.

ghukill · 2026-03-03T15:46:17Z

.github/workflows/ci.yml

-    uses: mitlibraries/.github/.github/workflows/python-shared-lint.yml@main
+    name: Run linters
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v7
+
+      - name: Create virtual environment
+        run: make install
+
+      - name: Run black
+        run: uvx black --check --diff .
+
+      - name: Run mypy
+        run: uv run mypy .
+
+      - name: Run ruff
+        run: uv run ruff check .


Given the dev dependency for black fix proposed in another comment, I think you could revert back to the shared uv-based linting workflow.

That, itself, basically falls back on make lint, so you can tailor that linting as you see fit for this project (e.g. removing the pip-audit call).

Yup, full agreement. I had initially forked the workflow to debug if it was older versions being problematic but that was not the case and with your help I've got it working with the shared workflow. We can address updating the workflow to use update checkout and uv-setup separately.

ghukill · 2026-03-03T15:48:29Z

README.md

+### Invoking Lambda via HTTP requests
+
+The following outlines how to run the Lambda SAM docker image as an HTTP endpoint, accepting requests and returning respnoses similar to a lambda behind an ALB, Function URL, or API Gateway.


Nice add! I was concerned at first glance that this SAM README text was heavily focused on an HTTP server use case.... but I reckon that's how this lambda will be used. So, awesome, excellent.

I promise I just copied this from your PR, I put zero thought into it... so yay you last May!

ghukill · 2026-03-03T15:52:25Z

README.md

+Response should have an HTTP status of `200` and respond with:
+```json
+{
+    "response": "pong"
+}
+```

-## Running a Specific Handler Locally with Docker
+### Invoking Lambda directly

-If this repo contains multiple lambda functions, you can call any handler you copy into the container (see Dockerfile) by name as part of the `docker run` command:
+While Lambdas can be invoked via HTTP methods (ALB, Function URL, etc.), they are also often invoked directly with an `event` payload.  To do so with SAM, you do **not** need to first start an HTTP server with `make sam-run`, you can invoke the function image directly:

-```bash
-docker run -p 9000:8080 my_function:latest lambdas.<a-different-module>.lambda_handler
+```shell
+echo '{"action": "ping","challenge_secret":"totally-local-archival-packaging"}' | sam local invoke -e -
+```
+
+Response:
+```text
+{"statusCode": 200, "statusDescription": "200 OK", "headers": {"Content-Type": "application/json"}, "isBase64Encoded": false, "body": "{\"response\": \"pong\"}"}
 ```

+As you can see from this response, the lambda is still returning a dictionary that _would_ work for an HTTP response, but is actually just a dictionary with the required information.
+
+It's unknown at this time if APT will get invoked via non-HTTP methods, but SAM will be helpful for testing and development if so.


Just noting that some of this is not currently true and/or never will be for this repo, looks like copy/paste from s3-bagit-validator. But it's early days! Not blocking, just noting.

For example, my response from make sam-http-ping:

% make sam-http-ping curl --location 'http://localhost:3000/myapp' \ --header 'Content-Type: application/json' \ --data '{"msg":"in a bottle"}' You have successfully called this lambda!%

Ha, this is copy pasta from the upstream PR which is likely copy pasta from s3-bagit-validator... I'll take a closer look and adjust as appropriate. Thanks for actually reading the words!

ghukill · 2026-03-03T15:53:17Z

tests/test_my_function.py

-def test_my_function_doesnt_configure_sentry_if_dsn_not_present(caplog, monkeypatch):
-    monkeypatch.delenv("SENTRY_DSN", raising=False)
-    reload(my_function)
-    assert "No Sentry DSN found, exceptions will not be sent to Sentry" in caplog.text
-
-
-def test_lambda_handler_missing_workspace_env_raises_error(monkeypatch):
-    monkeypatch.delenv("WORKSPACE", raising=False)
-    with pytest.raises(RuntimeError) as error:
-        my_function.lambda_handler({})
-    assert "Required env variable WORKSPACE is not set" in str(error)


ghukill · 2026-03-03T15:54:06Z

.github/workflows/ci.yml

+        run: make install
+
+      - name: Run black
+        run: uvx black --check --diff .


As noted in a couple of comments for restoring a successful install of black, might be worth revisiting this use of uvx which may not work in CI and/or seeing the comment below of reverting back to the shared workflow.

ghukill

Looking good! Able to run things locally with the black updates.

JPrevost · 2026-03-03T16:35:58Z

@ghukill would you mind reviewing again? I've properly installed back, reverted to our shared workflow, and updated the docs to be less inaccurate (they'll grow over time, but I believe they are closer to where they should be for starting out)

ghukill

Approval stands! Looks good for the uv, SAM, python 3.14 base.

Why are these changes being introduced: * `uv` is our preferred way to manage Python dependencies and virtual environments * Python 3.14 is the latest stable release. * Some additional changes were made for developer ergonomics in this cross team repository. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-425 How does this address that need: * Copies most of the changes from the [upstream PR](MITLibraries/python-lambda-template#58) * Updates to python 3.14 * Updates uv to latest * Updates all dependencies * Removes `pip-audit` from pre-commit hooks as we will manage dependency security concners with `renovate` via GitHub integration Document any side effects to this change: * This integrates changes that have not merged into the upstream template repository manually. We may have missed changes or upstream may choose different paths than they were exploring when we copied the changes.

JPrevost requested a review from ghukill March 3, 2026 14:48

ghukill reviewed Mar 3, 2026

View reviewed changes

ghukill self-requested a review March 3, 2026 16:19

ghukill approved these changes Mar 3, 2026

View reviewed changes

JPrevost requested a review from ghukill March 3, 2026 16:34

ghukill approved these changes Mar 3, 2026

View reviewed changes

JPrevost force-pushed the use-425-initial-lambda branch from 7d10de4 to 57c9ac1 Compare March 3, 2026 17:44

JPrevost merged commit f2e4e1a into main Mar 3, 2026
2 checks passed

JPrevost deleted the use-425-initial-lambda branch March 3, 2026 17:45

		### Invoking Lambda via HTTP requests

		The following outlines how to run the Lambda SAM docker image as an HTTP endpoint, accepting requests and returning respnoses similar to a lambda behind an ALB, Function URL, or API Gateway.

Conversation

JPrevost commented Mar 3, 2026

Purpose and background context

How can a reviewer manually see the effects of these changes?

Includes new or updated dependencies?

Changes expectations for external applications?

What are the relevant tickets?

Code review

Uh oh!

ghukill left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghukill left a comment

Choose a reason for hiding this comment

Uh oh!

JPrevost commented Mar 3, 2026

Uh oh!

ghukill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants