Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Oct 20, 2025

Developer

As part of our core UI work for USE UI, we identified some style changes we'd like to make to the footer and institute footer that come from the theme gem.

This work adjusts the USE UI footer to match these styles by:

  • Overriding the layout partials from the theme gem
  • Implementing style overrides for the styles from mitlib-style
  • Ensures responsive behavior down to smallest breakpoint
  • Adds new focus outline to match work done in header

This work does NOT include:

  • Heavily refactoring the markup of these elements. The style changes required for this phase of USE are small, and I'd prefer to refactor the markup of this later, and globally.
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 20, 2025

Pull Request Test Coverage Report for Build 18664670319

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.287%

Totals Coverage Status
Change from base Build 18603777561: 0.1%
Covered Lines: 918
Relevant Lines: 934

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-81-odl94tveyg October 20, 2025 20:52 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-81-odl94tveyg October 20, 2025 20:53 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-81-odl94tveyg October 20, 2025 20:55 Inactive
@JPrevost JPrevost self-assigned this Oct 21, 2025
/>
</a>

<div class="license">Content created by the MIT Libraries, <a href="https://creativecommons.org/licenses/by-nc/4.0/">CC BY-NC</a> unless otherwise noted. <a href="https://libraries.mit.edu/research-support/notices/copyright-notify/">Notify us about copyright concerns</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat outside the scope of this PR as it is carrying forward wording from before, However, much of what we display is metadata from other systems and very little of it is explicitly licensed CC-BY-NC and we never otherwise note that. This probably only belongs on the WordPress site and maybe LibGuides. We can land this as-is now, but I'd prefer we also open a ticket to explicitly review it with the intent of removal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPrevost Makes sense... would this be a PW ticket or a USE ticket?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djanelle-mit let's make it USE as it is where our main focus is right now and the change I am suggesting is in USE UI. Thanks!

@djanelle-mit djanelle-mit merged commit 53c2be7 into main Oct 21, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-81 branch October 21, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants