- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Override theme gem styling for footer and institute footer #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Pull Request Test Coverage Report for Build 18664670319Details
 
 💛 - Coveralls | 
    
| /> | ||
| </a> | ||
| 
               | 
          ||
| <div class="license">Content created by the MIT Libraries, <a href="https://creativecommons.org/licenses/by-nc/4.0/">CC BY-NC</a> unless otherwise noted. <a href="https://libraries.mit.edu/research-support/notices/copyright-notify/">Notify us about copyright concerns</a>. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somewhat outside the scope of this PR as it is carrying forward wording from before, However, much of what we display is metadata from other systems and very little of it is explicitly licensed CC-BY-NC and we never otherwise note that. This probably only belongs on the WordPress site and maybe LibGuides. We can land this as-is now, but I'd prefer we also open a ticket to explicitly review it with the intent of removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPrevost Makes sense... would this be a PW ticket or a USE ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djanelle-mit let's make it USE as it is where our main focus is right now and the change I am suggesting is in USE UI. Thanks!
Developer
As part of our core UI work for USE UI, we identified some style changes we'd like to make to the footer and institute footer that come from the theme gem.
This work adjusts the USE UI footer to match these styles by:
This work does NOT include:
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing