Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Oct 29, 2025

Developer

As part of our Core USE UI work we implemented a new header and navigation component. This component was reviewed by UXWS and they noticed the responsive behavior when there are links present (currently only on GeoData) needed to be fixed.

This work:

  • Adds responsive behavior to the navigation so links wrap below the logo and title lockup on smaller screen sizes.
  • Conditionally shows the navigation when links are present
  • Removes the unnecessary Home nav item. This is available as a link around the Title right now.
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 18916780231

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.204%

Totals Coverage Status
Change from base Build 18845580939: 0.0%
Covered Lines: 820
Relevant Lines: 835

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-130-yqpu58mko October 29, 2025 16:50 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-130-yqpu58mko October 29, 2025 17:30 Inactive
@JPrevost JPrevost self-assigned this Oct 30, 2025
@djanelle-mit djanelle-mit merged commit 241ffc6 into main Oct 30, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-130 branch October 30, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants