Show correct search form in GeoData full records #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19074153354Details
💛 - Coveralls |
JPrevost
reviewed
Nov 4, 2025
app/views/record/view.html.erb
Outdated
|
|
||
| <%= render(partial: 'shared/site_title') %> | ||
| <%= render(partial: 'search/form')%> | ||
| <%= render(partial: 'search/form_geo')%> |
There was a problem hiding this comment.
This makes me nervous that all full record views will use the geo form when we move in that direction. Is there a reason to not wrap this in our feature check like we do in other places in this template?
There was a problem hiding this comment.
Good point. I didn't bother since GeoData is the only app using that feature, but I suppose USE UI will at some point, too.
JPrevost
approved these changes
Nov 4, 2025
Why these changes are being introduced: USE UI uses a different search form partial than GeoData. When this change was made, we did not update the form partial loaded in the full record view. Relevant ticket(s): * [USE-157](https://mitlibraries.atlassian.net/browse/USE-157) How this addresses that need: This updates the `record_geo` partial to load the `form_geo` partial when the GeoData feature is enabled. Side effects of this change: None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
USE UI uses a different search form partial than
GeoData. When this change was made, we did not
update the form partial loaded in the full record
view.
Relevant ticket(s):
How this addresses that need:
This updates the
record_geopartial to load theform_geopartial.Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
To confirm, execute a search with the GeoData feature enabled and click a result title to get to the full record view. The search form above the record should be the advanced search form with geospatial fields, not the simple search form from USE.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing