Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Nov 3, 2025

Why these changes are being introduced:

A condition in the load_primo_results method in the Search Controller renders the Primo continuation partial if results are empty. This is necessary because of erratic behavior by the Primo search API, but it is problematic because the condition also triggers if the search returns no results.

Relevant ticket(s):

How this addresses that need:

This updates the problematic branch of the conditional so it also checks if the current page is 2 or higher before rendering the Primo continuation partial.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

Please confirm normal functionality in GeoData (execute geospatial search, use filters, use pagination, open full record view).

Please also confirm normal behavior (i.e., no results are signaled when appropriate) in the TIMDEX tab by adding tab=primo to the URL params.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

A condition in the `load_primo_results` method in the Search Controller
renders the Primo continuation partial if results are empty. This is
necessary because of erratic behavior by the Primo search API, but it is
problematic because the condition also triggers if the search returns no
results.

Relevant ticket(s):

- [USE-152](https://mitlibraries.atlassian.net/browse/USE-152)

How this addresses that need:

This updates the problematic branch of the conditional so it also checks
if the current page is 2 or higher before rendering the Primo
continuation partial.

Side effects of this change:

None.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19045354492

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.284%

Totals Coverage Status
Change from base Build 18977808186: 0.0%
Covered Lines: 859
Relevant Lines: 874

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-152-z14tokfir November 3, 2025 18:36 Inactive
@JPrevost JPrevost self-assigned this Nov 4, 2025
@jazairi jazairi merged commit cf5624d into main Nov 4, 2025
5 checks passed
@jazairi jazairi deleted the use-152 branch November 4, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants