Show Primo continuation partial only beyond page 1 #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
A condition in the
load_primo_resultsmethod in the Search Controller renders the Primo continuation partial if results are empty. This is necessary because of erratic behavior by the Primo search API, but it is problematic because the condition also triggers if the search returns no results.Relevant ticket(s):
How this addresses that need:
This updates the problematic branch of the conditional so it also checks if the current page is 2 or higher before rendering the Primo continuation partial.
Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
Please confirm normal functionality in GeoData (execute geospatial search, use filters, use pagination, open full record view).
Please also confirm normal behavior (i.e., no results are signaled when appropriate) in the TIMDEX tab by adding
tab=primoto the URL params.Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing