Add openssl to gemfile #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The openssl gem is included in the Ruby standard library, but there is a bug in the included version (
3.3.0) that causes it to fail with OpenSSL 3.6.0.Relevant ticket(s):
N/A.
How this addresses that need:
This includes the openssl gem in the Gemfile, thus installing the latest version rather than what is provided by standard Ruby. This is recommended by openssl gem maintainers.
Side effects of this change:
This is something to remember for future perplexing bugs, because this issue could happen with any gem included in the Ruby standard library.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
To trigger the SSL errors, OpenSSL must be version 3.6.0. You can confirm this by running
openssl --version. If the version is lower than 3.6.0, upgrade OpenSSL (brew upgrade openssl). You should then see the Primo API return errors in your local development environment onmain. Switching to this branch and installing bundler dependencies should resolve the error.Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing