Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Nov 4, 2025

Why these changes are being introduced:

The openssl gem is included in the Ruby standard library, but there is a bug in the included version (3.3.0) that causes it to fail with OpenSSL 3.6.0.

Relevant ticket(s):

N/A.

How this addresses that need:

This includes the openssl gem in the Gemfile, thus installing the latest version rather than what is provided by standard Ruby. This is recommended by openssl gem maintainers.

Side effects of this change:

This is something to remember for future perplexing bugs, because this issue could happen with any gem included in the Ruby standard library.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

To trigger the SSL errors, OpenSSL must be version 3.6.0. You can confirm this by running openssl --version. If the version is lower than 3.6.0, upgrade OpenSSL (brew upgrade openssl). You should then see the Primo API return errors in your local development environment on main. Switching to this branch and installing bundler dependencies should resolve the error.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

The openssl gem is included in the Ruby standard library, but there is a
[bug](ruby/openssl#949) in the included
version (`3.3.0`) that causes it to fail with OpenSSL 3.6.0.

Relevant ticket(s):

N/A.

How this addresses that need:

This includes the openssl gem in the Gemfile, thus installing the latest
version rather than what is provided by standard Ruby. This is
[recommended by openssl gem maintainers](ruby/openssl#949 (comment)).

Side effects of this change:

This is something to remember for future perplexing bugs, because this
issue could happen with any gem included in the Ruby standard library.
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-164-5ww70wmcx November 4, 2025 15:15 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19073381728

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.284%

Totals Coverage Status
Change from base Build 18977808186: 0.0%
Covered Lines: 859
Relevant Lines: 874

💛 - Coveralls

@JPrevost JPrevost self-assigned this Nov 4, 2025
@jazairi jazairi merged commit b4195f1 into main Nov 4, 2025
5 checks passed
@jazairi jazairi deleted the use-164 branch November 4, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants