Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Nov 7, 2025

https://mitlibraries.atlassian.net/browse/USE-158

To test, in staging do the following.

  • Run a search
  • Change to page 2
  • Refresh the page
  • Click the other tab… you’ll be on page 2 of that tab

In the PR build do the same, and you should be on page 1 as expected.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Nov 7, 2025

Pull Request Test Coverage Report for Build 19179639168

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.865%

Totals Coverage Status
Change from base Build 19179601006: 0.0%
Covered Lines: 871
Relevant Lines: 890

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-158-ta-8uaokc November 7, 2025 18:56 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Nov 7, 2025
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed steps to reproduce this - once I actually followed all of them, I saw what you're talking about. I don't see that behavior in the review app.

I haven't flipped the review app into GeoData mode, because GeoData doesn't use these tabs - so I can't think of a way that this change would affect that instance of the app.

@JPrevost JPrevost force-pushed the use-158-tabs-page-one branch from a6462a6 to ec670e1 Compare November 7, 2025 19:56
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-158-ta-8uaokc November 7, 2025 19:56 Inactive
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think that's what we need / I thought you'd do.

:shipit:

@JPrevost JPrevost merged commit 131dabf into main Nov 7, 2025
5 checks passed
@JPrevost JPrevost deleted the use-158-tabs-page-one branch November 7, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants