Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Dec 2, 2025

Why are these changes being introduced:

  • Summary of the content on the tab is useful

Relevant ticket(s):

How does this address that need:

  • Adds a tab_description helper that sets a description based on the active_tab

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Dec 2, 2025

Pull Request Test Coverage Report for Build 19940704539

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.883%

Totals Coverage Status
Change from base Build 19906931799: 0.02%
Covered Lines: 971
Relevant Lines: 992

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-183-ta-3z5bzr December 2, 2025 20:39 Inactive
@JPrevost JPrevost force-pushed the use-183-tab-descriptions branch from b041cce to 077b8e9 Compare December 3, 2025 19:23
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-183-ta-3z5bzr December 3, 2025 19:23 Inactive
@jazairi jazairi self-assigned this Dec 4, 2025
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Why are these changes being introduced:

* Summary of the content on the tab is useful

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-183

How does this address that need:

* Adds a tab_description helper that sets a description based on the
  active_tab
@JPrevost JPrevost force-pushed the use-183-tab-descriptions branch from 077b8e9 to e9d524f Compare December 4, 2025 19:04
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-183-ta-3z5bzr December 4, 2025 19:04 Inactive
@JPrevost JPrevost merged commit dc5ffc3 into main Dec 4, 2025
5 checks passed
@JPrevost JPrevost deleted the use-183-tab-descriptions branch December 4, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants