Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Dec 10, 2025

Developer

This work styles the new dynamic callout boxes (search suggesitons) in USE UI results lists.

  • Added style to force boxes to be the same width when more than one are present
  • Tweaked one icon
  • Tweaked button copy
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Dec 10, 2025

Pull Request Test Coverage Report for Build 20106272027

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 98.142%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 7 94.81%
Totals Coverage Status
Change from base Build 20100834042: 0.2%
Covered Lines: 1109
Relevant Lines: 1130

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-265-hrd8cegax December 10, 2025 15:22 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-265-hrd8cegax December 10, 2025 16:44 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Dec 11, 2025
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that I see the impact of the new CSS rules, comparing production with the review build - things move maybe a pixel or two? The rules you're using make sense to me, though.

:shipit:

@djanelle-mit
Copy link
Contributor Author

I'm not entirely sure that I see the impact of the new CSS rules, comparing production with the review build - things move maybe a pixel or two? The rules you're using make sense to me, though.

:shipit:

@matt-bernhardt They mostly impacted the tabs where one box was MUCH wider than the other boxes due to the content length. Most of the tabs were like a 56/44% split though

@djanelle-mit djanelle-mit merged commit 8c4fbb4 into main Dec 11, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-265 branch December 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants