Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Dec 16, 2025

Developer

Now that LibKey links have landed in the UI, this work styles them to match other buttons. This work also includes a skeleton loader style that's available as a mixin (with customizable height and width props).

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@djanelle-mit djanelle-mit changed the title USE-282: Custom styles for skeleton loader encapsulated in a mixin. Tweaks to … USE-282: Styling libkey links Dec 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20271425733

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.906%

Totals Coverage Status
Change from base Build 20248186552: 0.0%
Covered Lines: 1169
Relevant Lines: 1194

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-282-xie0sqkdh December 16, 2025 14:33 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Dec 16, 2025
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I like that you've added an argument for the skeleton loader element, which feels like it will be helpful if we try to adopt the same pattern for TACOS interventions.

Thanks for fixing the class name in the libkey container, too :-)

@djanelle-mit djanelle-mit merged commit 6f12d6a into main Dec 16, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-282 branch December 16, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants