Skip to content

Conversation

@JPrevost
Copy link
Member

Why are these changes being introduced:

  • CDI was the only source that used a single string with multiple subjects
  • Normalizing these to individual subjects improves consistency across sources

Relevant ticket(s):

How does this address that need:

  • Updates the primo normaliztion to split subjects on ' ; ' delimiter
    • This should have no affect on Primo Alma data that does not use this format but should clean up the Primo CDI data

Document any side effects to this change:

  • Our full record fixture was update to reflect the typical CDI data. The test was not changed as our new code modifies the data to match the previous expected result.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why are these changes being introduced:

* CDI was the only source that used a single string with multiple subjects
* Normalizing these to individual subjects improves consistency across sources

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-303

How does this address that need:

* Updates the primo normaliztion to split subjects on ' ;  ' delimiter
  * This should have no affect on Primo Alma data that does not use this
    format but should clean up the Primo CDI data

Document any side effects to this change:

* Our full record fixture was update to reflect the typical CDI data.
  The test was not changed as our new code modifies the data to match
  the previous expected result.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20316244287

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.906%

Totals Coverage Status
Change from base Build 20312003545: 0.002%
Covered Lines: 1169
Relevant Lines: 1194

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants