Skip to content

Conversation

@JPrevost
Copy link
Member

Why are these changes being introduced:

  • The citations in Alma records are not expcted to be useful and are a bit messy.

Relevant ticket(s):

How does this address that need:

  • Skips normalizing citations in Alma records

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Dec 18, 2025

Pull Request Test Coverage Report for Build 20351909668

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.908%

Totals Coverage Status
Change from base Build 20351856151: 0.002%
Covered Lines: 1170
Relevant Lines: 1195

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-298-li-m4r0j2 December 18, 2025 21:13 Inactive
Why are these changes being introduced:

* The citations in Alma records are not expcted to be useful and are a
  bit messy.

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-298

How does this address that need:

* Skips normalizing citations in Alma records
@JPrevost JPrevost force-pushed the use-298-limit-citation-to-cdi branch from 1088d04 to fd4a8ec Compare December 18, 2025 21:29
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-298-li-m4r0j2 December 18, 2025 21:30 Inactive
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I'm slightly worried about fixture drift and the new test on line 92, since the test doesn't explicitly say that the full_record fixture uses an Alma recordid - so I needed to go look it up to help understand this pair of tests in context to each other.

But, it should also be pretty easy to diagnose in this hypothetitcal future, because changing the fixture in this way will immediately cause the test to fail. Maybe I have too much faith in future us, but I'm willing to take that risk at the moment.

:shipit:

@JPrevost JPrevost merged commit 43a0512 into main Dec 18, 2025
5 checks passed
@JPrevost JPrevost deleted the use-298-limit-citation-to-cdi branch December 18, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants