Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Jan 14, 2026

Developer

Previously, we had a message when Primo timed out that wasn't as user friendly as we'd prefer. This work updates that message and adjusts the styling to be closer to our design system component for Alert.

This required some new semantic color variables.

This work does NOT adjust the other flavors of Alert. Since they're probably shared with GeoData, it seems wise to make as few changes as possible until we can investigate all of the tendrils.

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Jan 14, 2026

Pull Request Test Coverage Report for Build 21033633891

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/search_controller.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 20960248789: 0.0%
Covered Lines: 1198
Relevant Lines: 1223

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-316-xlgggikni January 14, 2026 14:08 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Jan 14, 2026
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is a "request changes" or just a concern because I'm failing to review this accurately - but I don't see the icon I think you're intending in the alert? I've set the review app to throw the error very quickly (the threshold is a tenth of a second), and I've been able to see the error pretty consistently that way.


&:before{
color: $color-icon-danger;
content: "\f05e";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the cause is, but when I look at the review app (and running the branch locally) I see an empty icon in the alert.

Screenshot 2026-01-14 at 2 37 00 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh fascinating... This problem happened when working on Wordpress... I have the icon font locally so it appeared on my local environment, but I must not be referencing it correctly for the version we have on our CDN. I'll update this!

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-316-xlgggikni January 15, 2026 13:50 Inactive
@djanelle-mit
Copy link
Contributor Author

@matt-bernhardt Can you check the review app again for me? I updated the reference (I put a reference to version 6 instead of 7. 7 is the one included in USE...). It looks good on my end, even when disabling local font rendering in chrome inspect, but would love someone without the local font to confirm.

@matt-bernhardt
Copy link
Member

Yep! I see the icon now. I'll switch this to approved.

Screenshot 2026-01-15 at 11 35 23 AM

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@djanelle-mit djanelle-mit merged commit 37a9f37 into main Jan 15, 2026
5 checks passed
@djanelle-mit djanelle-mit deleted the use-316 branch January 15, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants