Add TIMDEX and Primo record ids to markup #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: As part of our measurement strategy, there are scenarios where we want to have access to the record ID values from Primo and TIMDEX. These values are not meaningful to users, so they shouldn't be visible, but having them in a data attribute can be very useful. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/use-197 ** How does this address that need: The Primo and TIMDEX normalizers already use these record IDs, and pass them to the view layer. GeoData makes use of them for some functionality already. This adds a recordId data attribute to the containing list item for all view templates, for use by analytics scripts. ** Document any side effects to this change: None
Pull Request Test Coverage Report for Build 21006628782Details
💛 - Coveralls |
JPrevost
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our measurement strategy, there are scenarios where we want to have access to the record ID values from Primo and TIMDEX. These values are not meaningful to users, so they shouldn't be visible, but having them in a data attribute can be very useful.
The Primo and TIMDEX normalizers already use these record IDs, and pass them to the view layer. GeoData makes use of them for some functionality already.
This adds a recordId data attribute to the containing list item for all view templates, for use by analytics scripts.
Ticket: https://mitlibraries.atlassian.net/browse/use-197
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing