Update Primo result partial to use new FRBR property #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The last commit in USE-329 introduced a bug. It
renamed the
frbrizedproperty of normalizedPrimo records without making the corresponding
change in the Primo result partial.
This made the conditional that triggers the FRBR
callout unreachable in the code. The test suite
did not catch it because we do not test view
behavior.
Relevant ticket(s):
How this addresses that need:
This updates the Primo result partial to use
the renamed property (
dedup_record) to checkfor FRBRization.
Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
See the JIRA ticket for example searches to confirm behavior.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing