Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Jan 28, 2026

Why these changes are being introduced:

The last commit in USE-329 introduced a bug. It
renamed the frbrized property of normalized
Primo records without making the corresponding
change in the Primo result partial.

This made the conditional that triggers the FRBR
callout unreachable in the code. The test suite
did not catch it because we do not test view
behavior.

Relevant ticket(s):

How this addresses that need:

This updates the Primo result partial to use
the renamed property (dedup_record) to check
for FRBRization.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

See the JIRA ticket for example searches to confirm behavior.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

The last commit in USE-329 introduced a bug. It
renamed the `frbrized` property of normalized
Primo records without making the corresponding
change in the Primo result partial.

This made the conditional that triggers the FRBR
callout unreachable in the code. The test suite
did not catch it because we do not test view
behavior.

Relevant ticket(s):

- [USE-329](https://mitlibraries.atlassian.net/browse/USE-329)
- [USE-354](https://mitlibraries.atlassian.net/browse/USE-354)

How this addresses that need:

This updates the Primo result partial to use
the renamed property (`dedup_record`) to check
for FRBRization.

Side effects of this change:

None.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21445986432

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.119%

Totals Coverage Status
Change from base Build 21298507000: 0.0%
Covered Lines: 1304
Relevant Lines: 1329

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-354-fi-s9juhb January 28, 2026 16:15 Inactive
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:


<%# FRBR indicator: show a small callout and link to the Primo record %>
<% if result[:frbrized] %>
<% if result[:dedup_record] %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I knew we had seen this working. It was just the last changes to make the naming clearer that a condition got missed. Totally makes sense, I thought I was losing it :)

@jazairi jazairi merged commit 5487dff into main Jan 28, 2026
5 checks passed
@jazairi jazairi deleted the use-354-fix-frbr branch January 28, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants