Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Feb 3, 2026

Why these changes are being introduced:

We had removed this feature, but UXWS would like
it back.

Relevant ticket(s):

How this addresses that need:

This removes the clause that excludes journals
from availability statements.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

We had removed this feature, but UXWS would like
it back.

Relevant ticket(s):

- [USE-363](https://mitlibraries.atlassian.net/browse/USE-363)

How this addresses that need:

This removes the clause that excludes journals
from availability statements.

Side effects of this change:

None.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21641843340

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.12%

Totals Coverage Status
Change from base Build 21631890289: 0.0%
Covered Lines: 1305
Relevant Lines: 1330

💛 - Coveralls

@JPrevost
Copy link
Member

JPrevost commented Feb 3, 2026

Can you see if you can get the "View journal contents" link on its own line and keep the button it had before we reintroduced this?

Holdings link good in this example, but the button-ish link and the two links on the same line feel weird.

Screenshot 2026-02-03 at 1 54 17 PM

This example (prod) has the button link I'm referring to:

Screenshot 2026-02-03 at 1 56 14 PM

It sort of feels like maybe the holdings link just moves outside of the fulfillment links area? Not sure. If it gets messy we can consult Dave.

Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping we can adjust the link displays a bit, see screenshots and comment.

@jazairi
Copy link
Contributor Author

jazairi commented Feb 3, 2026

@JPrevost Oh, good catch. I didn't have ThirdIron enabled locally. Should be pretty straightforward; I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants